Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: incorrect grouping of metrics during aggregation #13

Closed
yorugac opened this issue Jan 20, 2022 · 2 comments
Closed

Bug: incorrect grouping of metrics during aggregation #13

yorugac opened this issue Jan 20, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@yorugac
Copy link
Collaborator

yorugac commented Jan 20, 2022

Described in community forum: https://community.k6.io/t/counters-not-starting-from-zero/2737
Both actual and expected behavior are included in the above description.

The cause: internal aggregation of metrics in the extension is happening by names of metrics and doesn't take labels into account. Ideally, this should be resolved by grafana/k6#1831. However, that issue may take quite a lot of time to resolve fully, so it'd be good if a quicker solution can be added here first. E.g. once some design solutions proposed to grafana/k6#1831, it might make sense to evaluate them here, in the extension first.

Currently considered blocked by grafana/k6#1831 and should be re-visited upon progress there.

@yorugac yorugac added the bug Something isn't working label Jan 20, 2022
@yorugac yorugac self-assigned this Jan 20, 2022
@yorugac yorugac removed their assignment Mar 25, 2022
@mschenk42
Copy link

mschenk42 commented Jun 28, 2022

We've noticed trend metrics for requests with labels (name label in particular) are not correct. When grouping by the name label (request) the trend metrics are all the same for each name label value. Would this issue be why that is the case?

@codebien
Copy link
Contributor

Hi @mschenk42, yes, it is the same issue. Hopefully, we will get fixed in the next releases, we are actively working on the main issue.

In the meanwhile, you could consider to workaround creating custom metrics per endpoint, you probably need to tune the System Tags so k6 doesn't generate too much time series.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants