Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Page APIs to async #1307

Open
1 of 6 tasks
Tracked by #428
inancgumus opened this issue May 6, 2024 · 0 comments
Open
1 of 6 tasks
Tracked by #428

Migrate Page APIs to async #1307

inancgumus opened this issue May 6, 2024 · 0 comments
Assignees
Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes

Comments

@inancgumus
Copy link
Member

inancgumus commented May 6, 2024

What

Migrate the following APIs according to the How section in #428:

Class Method Current k6 Return PW return
Page $ ElementHandle|null Promise<ElementHandle<SVGElement|HTMLElement>|null>
Page $$ ElementHandle[] Promise<ElementHandle<SVGElement|HTMLElement>[]>
Page bringToFront void Promise
Page check void Promise
Page close void Promise
Page content string Promise
Page dblclick void Promise
Page dispatchEvent void Promise
Page emulateMedia void Promise
Page emulateVisionDeficiency void not found in Playwright
Page evaluate<R, Arg> R Promise
Page evaluateHandle<R, Arg> JSHandle Promise<SmartHandle>
Page fill void Promise
Page focus void Promise
Page getAttribute null|string Promise<null|string>
Page hover void Promise
Page innerHTML string Promise
Page innerText string Promise
Page inputValue string Promise
Page isChecked boolean Promise
Page isDisabled boolean Promise
Page isEditable boolean Promise
Page isEnabled boolean Promise
Page isHidden boolean Promise
Page isVisible boolean Promise
Page on void this
Page opener Page|null Promise<null|Page>
Page press void Promise
Page reload null|Response Promise<null|Response>
Page screenshot ArrayBuffer Promise
Page selectOption string[] Promise<Array>
Page setContent void Promise
Page setExtraHTTPHeaders void Promise
Page setInputFiles void Promise
Page setViewportSize void Promise
Page tap void Promise
Page textContent string Promise<null|string>
Page throttleCPU void not found in Playwright
Page throttleNetwork void not found in Playwright
Page title string Promise
Page type void Promise
Page uncheck void Promise
Page viewportSize {width:number;height:number;} null|{width:number;height:number;}
Page waitForLoadState void Promise
Page waitForSelector ElementHandle Promise<null|ElementHandle<SVGElement|HTMLElement>>
Page waitForTimeout void Promise

For details on the Why and How, check the overarching issue in #428.

Tasks

  1. mapping refactor stability
    inancgumus
  2. mapping refactor stability
    inancgumus
@inancgumus inancgumus mentioned this issue May 6, 2024
17 tasks
@inancgumus inancgumus added async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes labels May 6, 2024
@inancgumus inancgumus self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Development

No branches or pull requests

1 participant