You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Go code generator does not currently handle struct unifications correctly. Rather than either inlining or embedding the type, it simply omits it entirely.
The initial fix here should should embed the type, without any option for inlining. If a use case presents itself, we can add a separate config option to enable inlining later.
This case is covered by the testdata/lineage/unifyref.txtar, and will impact (among probably many others) the Azure Monitor plugin in grafana
The text was updated successfully, but these errors were encountered:
Hey @spinillos, @sdboyer,
I see the aforementioned PR has been merged, and indeed the lineage/unifyref case was removed from the ToDo list there. So, can we close this issue? Or is there any other work still remaining?
Thanks!
The Go code generator does not currently handle struct unifications correctly. Rather than either inlining or embedding the type, it simply omits it entirely.
The initial fix here should should embed the type, without any option for inlining. If a use case presents itself, we can add a separate config option to enable inlining later.
This case is covered by the
testdata/lineage/unifyref.txtar
, and will impact (among probably many others) the Azure Monitor plugin in grafanaThe text was updated successfully, but these errors were encountered: