Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error output from Validate(), Translate(), and vmuxers #142

Open
mildwonkey opened this issue May 10, 2023 · 1 comment
Open

Improve error output from Validate(), Translate(), and vmuxers #142

mildwonkey opened this issue May 10, 2023 · 1 comment
Labels
bug Something isn't working prio/mid Medium priority readiness/minimum Requisite for achieving a minimum readiness

Comments

@mildwonkey
Copy link

Translate() errors which report an expected vs. actual values are sometimes, but not always, reversed:

validation failed, data is not an instance:
	schema expected `null`
		dashboard.json:18:13
		/scthema/dashboard_kind.cue:571:13
	but data contained `string`

I attempted to address this in #140 , which is when I learned that it's not always reversed.

@sdboyer sdboyer added the bug Something isn't working label May 10, 2023
@sdboyer sdboyer changed the title Improve error output from Translate() Improve error output from Validate() and Translate() May 10, 2023
@sdboyer
Copy link
Contributor

sdboyer commented May 10, 2023

updated title just to reflect that these particular errors are coming from the Validate() call that is made internally by vmuxers before they call Translate()

(Which also points to another issue, that the error model for thema - epic is #44 - needs to include a clear way of differentiating, presumably with errors.Is(), between different classes of errors that may occur during processing of input bytes to vmuxers)

@sdboyer sdboyer changed the title Improve error output from Validate() and Translate() Improve error output from Validate(), Translate(), and vmuxers May 10, 2023
@joanlopez joanlopez added prio/mid Medium priority readiness/minimum Requisite for achieving a minimum readiness labels Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio/mid Medium priority readiness/minimum Requisite for achieving a minimum readiness
Projects
None yet
Development

No branches or pull requests

3 participants