Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Dashboard JSON from external store #1288

Open
abacus3 opened this issue Jan 17, 2024 · 1 comment
Open

Get Dashboard JSON from external store #1288

abacus3 opened this issue Jan 17, 2024 · 1 comment

Comments

@abacus3
Copy link

abacus3 commented Jan 17, 2024

The current API implementation requires the specification of the entire Grafana Dashboard JSON to be provided in the terraform resource property config_json directly.

This works well with Terraform per se.
Nevertheless, other tools using this provider, such as the crossplane provider-grafana, may encounter issues with limitations in other ecosystems, such as the k8s object size limit. (which in combination with the well-known last-applied k8s annotation results in only half of the acual object size to be usable)

In order to support large dashboards with k8s crossplane provider-grafana, I'd like to propose the following feature:
Allow dashboards to be loaded from external data stores, such as git, s3, filesystem etc.

Additional clients and config of those for the external stores would be required here. Credentials for the external storage system should be provided in the resource definition, not in the provider section, so that multiple backend systems can be supported independently.

@julienduchesne
Copy link
Member

julienduchesne commented Jan 17, 2024

I don't think I will implement this. We have hundreds of dashboards here and have never encountered any one near the 1MB limit. You can apply resources about 4x as big (right up to the 1MB storage limit) using server side applies, client side applies being limited to 200-300KB in practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants