Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate from jaeger-sdk to otel-sdk #2224

Closed
frzifus opened this issue Mar 17, 2023 · 3 comments · May be fixed by #3646
Closed

migrate from jaeger-sdk to otel-sdk #2224

frzifus opened this issue Mar 17, 2023 · 3 comments · May be fixed by #3646
Labels
stale Used for stale issues / PRs

Comments

@frzifus
Copy link
Contributor

frzifus commented Mar 17, 2023

Is your feature request related to a problem? Please describe.

Currently all tempo components are instrumented using the Jaeger-SDK that is at end of life. This requires additional configurations to collect those traces and might leads to future security issues.

Describe the solution you'd like
Migrate to OTEL-sdk. ^^

Describe alternatives you've considered

Additional context
@joe-elliott
Copy link
Member

Yes! I agree we need to move forward to the OTEL clients. At one point there was an attempt to do this:

tempo/cmd/tempo/main.go

Line 230 in 944e5ae

func installOpenTelemetryTracer(config *app.Config) (func(), error) {

but for some reason context was not propagating between services and the work got shelved. If you, or anyone else, would like to take up figuring out the last bits we would be grateful.

@frzifus
Copy link
Contributor Author

frzifus commented Mar 17, 2023

I would like to look at it more closely. But I will not be able to do that in the next weeks. 😔

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added the stale Used for stale issues / PRs label May 17, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
@andreasgerstmayr andreasgerstmayr mentioned this issue May 3, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Used for stale issues / PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from OpenTracing to OpenTelemetry instrumentation andreasgerstmayr/tempo
2 participants
@joe-elliott @frzifus