Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination for tag search endpoint #3599

Open
gng0 opened this issue Apr 23, 2024 · 5 comments
Open

Pagination for tag search endpoint #3599

gng0 opened this issue Apr 23, 2024 · 5 comments

Comments

@gng0
Copy link

gng0 commented Apr 23, 2024

We've been encountering an issue with 500 error responses when making requests to the /api/v2/search/tag/name/values endpoint. This is due to the response size exceeding the maximum configured value, as outlined in the Grafana documentation here: https://grafana.com/docs/tempo/latest/troubleshooting/search-tag/

Although the documentation suggests reducing the cardinality of tags or increasing the max_bytes_per_tag_values_query parameter, we don't think these solutions are feasible in the long-run.

We'd like to suggest pagination on this API endpoint, which will resolve the current issue and be a more scalable solution. It would also lead to better user experience as the data load times would be able to be reduced.

@joe-elliott
Copy link
Member

joe-elliott commented Apr 23, 2024

pagination is difficult, but likely not impossible. i'd have to think on it some.

we have recently added a streaming tags endpoint that might meet your needs. it can be exercised using the tempo-cli tool (or any appropriate grpc client):

https://github.com/grafana/tempo/blob/main/cmd/tempo-cli/cmd-query-search-tag-values.go
#3460

this will be released in 2.5.

@gng0
Copy link
Author

gng0 commented Apr 30, 2024

Hi @joe-elliott - sorry I think my initial comment might have been a bit misleading, as we aren't directly calling that API endpoint. The endpoint is being hit from the “Search” tab in the default Grafana Tempo plugin. So we are seeing 500's every time someone loads that page in “Explore” mode.

Will the new streaming endpoint you mentioned be used in the Grafana Tempo plugin UI?

@joe-elliott
Copy link
Member

joe-elliott commented Apr 30, 2024

Will the new streaming endpoint you mentioned be used in the Grafana Tempo plugin UI?

The Grafana team is aware of this endpoint, but has no immediate plans to implement it. Since you are clearly showing interest do you want to create an issue on https://github.com/grafana/grafana/? I can +1 the issue and make sure it's tagged appropriately.

@jcmackie
Copy link

jcmackie commented May 1, 2024

Hello @joe-elliott ,
Thanks for the response.

I was going to ask you if the multiplexed http/grpc issues with TraceQL streaming is resolved, but then I searched and saw your PR: #3300

Before I start playing around with our dev environment, did the above PR make it possible to multiplex http/grpc connections over an AWS ALB?

@joe-elliott
Copy link
Member

Before I start playing around with our dev environment, did the above PR make it possible to multiplex http/grpc connections over an AWS ALB?

I'm honestly not sure, but I don't see why not. You'd need to forward http2/http to the same port in Tempo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants