Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Loki chart fails to render proper YAML when add more than one ex… #12911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Loki chart fails to render proper YAML when add more than one ex… #12911

wants to merge 1 commit into from

Conversation

ngclinflows
Copy link

…tra manifest (#12910)

What this PR does / why we need it:
Just a small fix to resolve my issue.

Which issue(s) this PR fixes:
Fixes #12910

Special notes for your reviewer:
I didn't bumped Helm Chart version myself

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ngclinflows ngclinflows requested a review from a team as a code owner May 8, 2024 07:23
@CLAassistant
Copy link

CLAassistant commented May 8, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/helm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loki chart fails to render proper YAML when add more than one extra manifest
2 participants
@ngclinflows @CLAassistant