diff --git a/lib/executor/executors_test.go b/lib/executor/executors_test.go index 60978d32482..acd420da09b 100644 --- a/lib/executor/executors_test.go +++ b/lib/executor/executors_test.go @@ -340,6 +340,7 @@ var configMapTestCases = []configMapTestCase{ }, {`{"carrival": {"executor": "constant-arrival-rate", "rate": 10, "duration": "10m", "preAllocatedVUs": 20, "maxVUs": 30}}`, exp{}}, {`{"carrival": {"executor": "constant-arrival-rate", "rate": 10, "duration": "10m", "preAllocatedVUs": 20, "maxVUs": 30, "timeUnit": "-1s"}}`, exp{validationError: true}}, + {`{"carrival": {"executor": "constant-arrival-rate", "rate": 10, "duration": "10m", "preAllocatedVUs": 20, "maxVUs": 30, "timeUnit": "0s"}}`, exp{validationError: true}}, { `{"carrival": {"executor": "constant-arrival-rate", "rate": 10, "duration": "10m", "preAllocatedVUs": 20}}`, exp{custom: func(t *testing.T, cm lib.ScenarioConfigs) { @@ -403,6 +404,7 @@ var configMapTestCases = []configMapTestCase{ {`{"varrival": {"executor": "ramping-arrival-rate", "preAllocatedVUs": 20, "maxVUs": 50}}`, exp{validationError: true}}, {`{"varrival": {"executor": "ramping-arrival-rate", "preAllocatedVUs": 20, "maxVUs": 50, "stages": []}}`, exp{validationError: true}}, {`{"varrival": {"executor": "ramping-arrival-rate", "preAllocatedVUs": 20, "maxVUs": 50, "stages": [{"duration": "5m", "target": 10}], "timeUnit": "-1s"}}`, exp{validationError: true}}, + {`{"varrival": {"executor": "ramping-arrival-rate", "preAllocatedVUs": 20, "maxVUs": 50, "stages": [{"duration": "5m", "target": 10}], "timeUnit": "0s"}}`, exp{validationError: true}}, {`{"varrival": {"executor": "ramping-arrival-rate", "preAllocatedVUs": 30, "maxVUs": 20, "stages": [{"duration": "5m", "target": 10}]}}`, exp{validationError: true}}, // TODO: more tests of mixed executors and execution plans diff --git a/lib/executor/ramping_arrival_rate.go b/lib/executor/ramping_arrival_rate.go index 8617f2550e5..17ba7038dcc 100644 --- a/lib/executor/ramping_arrival_rate.go +++ b/lib/executor/ramping_arrival_rate.go @@ -91,7 +91,7 @@ func (varc *RampingArrivalRateConfig) Validate() []error { errors = append(errors, fmt.Errorf("the startRate value can't be negative")) } - if varc.TimeUnit.TimeDuration() < 0 { + if varc.TimeUnit.TimeDuration() <= 0 { errors = append(errors, fmt.Errorf("the timeUnit must be more than 0")) }