Explore: Fix share link labels #86965
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifrost
requested review from
ashharrison90 and
L-M-K-B
and removed request for
a team
joshhunt
reviewed
Apr 26, 2024
| @@ -93,7 +93,7 @@ export function ShortLinkButtonMenu() { | |||
| { | |||
| key: 'copy-link-abs-time', | |||
| icon: 'clock-nine', | |||
| label: t('explore.toolbar.copy-link-abs-time', 'Copy Absolute Shortened URL'), | |||
| label: t('explore.toolbar.copy-link-abs-time', 'Copy Absolute URL'), | |||
There was a problem hiding this comment.
While we're nit-picking, absolute probably should have a lowercase A ✌️
gelicia
approved these changes
Apr 26, 2024
L-M-K-B
added
no-backport
L-M-K-B
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86964