Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup #85510

Open
43 tasks done
eledobleefe opened this issue Apr 3, 2024 · 0 comments
Assignees
Labels
area/frontend saga design system Issues related to the work of the Saga Design System type/epic Issue made of smaller issues

Comments

@eledobleefe
Copy link
Contributor

eledobleefe commented Apr 3, 2024

Although we added new layout components, such as Box and Stack, there are many places in our code where we can find these deprecated components. The aim here is to list them all and increasingly change Layout, HorizontalGroup and VerticalGroup into Stack or the most appropriate new layout component for each case.

Teams, owners of affected code:

  1. Alerting Frontend:
    Alerting: Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86841
  2. Dashboards Squad:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86831
  3. Dataviz Squad:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86844
  4. Explore squad:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86839
  5. App Platform Squad:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86863
  6. Frontend Platform
  7. Identity Access Team:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86864
  8. Observability Logs:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86869
  9. Observability Metrics:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86872
  10. Observability Traces and Profiling:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86874
  11. Partner Datasources:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86876
  12. Plugins Platform Frontend:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86878
  13. Sharing Squad:
    Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup  #86880

There is also code to modify in grafana-enterprise:
Deprecated layout component: get rid of HorizontalGroup


Frontend Platform

Remove HorizontalGroup and VerticalGroup

Remove HorizontalGroup

Remove VerticalGroup

@eledobleefe eledobleefe self-assigned this Apr 3, 2024
@eledobleefe eledobleefe added area/frontend type/epic Issue made of smaller issues labels Apr 3, 2024
@eledobleefe eledobleefe added the saga design system Issues related to the work of the Saga Design System label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend saga design system Issues related to the work of the Saga Design System type/epic Issue made of smaller issues
Projects
Status: ➕ In Progress (Non-roadmap)
Development

No branches or pull requests

1 participant