Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Make alert threshold visibility in graphs optional #7258

Closed
tomasv opened this issue Jan 13, 2017 · 40 comments · Fixed by #25705
Closed

[Feature request] Make alert threshold visibility in graphs optional #7258

tomasv opened this issue Jan 13, 2017 · 40 comments · Fixed by #25705

Comments

@tomasv
Copy link
Contributor

tomasv commented Jan 13, 2017

Hey 👋

For my use-cases I don't really need to see the thresholds of an alert in my graphs and they're pretty stark visually (red and the whole alertable area is tinted as well). That's why I was thinking that perhaps it would make sense to make it optional.

Maybe a checkbox "Show alert thresholds" in "Alert Config"? Or does "Display > Thresholds" make more sense for this?

@bergquist
Copy link
Contributor

I think this makes sense. PR would be appreciated!

@dbrgn
Copy link
Contributor

dbrgn commented Mar 11, 2017

Here's a case where it's especially distracting:

I have a system where I collect two temperature measurements. An alert happens if the first is >50°C or if the second is >70°C.

img

The diagram now shows a green heart to indicate that no alert situation is ongoing, but the second time series is in the red area:

img2

This looks as if an alert should happen.

Being able to change the appearance or to disable the visual threshold would be greatly appreciated.

@inklit
Copy link

inklit commented Jun 13, 2017

The alert threshold really makes my graph look like nonsense, so it would be great to make the redness optional.

Really at this point it's just polluting my graph.
http://i.imgur.com/3x9oFjG.png

@4szt4l
Copy link

4szt4l commented Dec 13, 2017

+1

Until then my workarounds:
Alert thresholds are showing only for the 1st condition.
So in the 1st line I setup something that will never happen and where the limit is outside the panel, then I add a original condition in the 2nd row with an OR.

Other alternative - if you use only 1 axis:
Move everything to the right axes and set left axis limit to something that is out of the alert range (though a (right-y) will be shown every line in the legends)

@NotTheEconomist
Copy link

Any update on this issue?

@timmmmmeh
Copy link

+1 to this. Right now I have a graph of server errors that alerts if the number of errors is greater than 0. The whole graph is shaded red so it'd be helpful to be able to disable this display.

@Eptis
Copy link

Eptis commented Oct 19, 2018

+1 for this feature. It was fine with the threshold features

@TheGoblinHero
Copy link

+1 also

@Grygon
Copy link

Grygon commented Nov 13, 2018

+1 here too. Right now I just have a dashboard that I never look at with alerts, but that seems stupid to me when it's all just repeats of existing panels.

@HenGold
Copy link

HenGold commented Nov 15, 2018

+1 here same as @ArmedChef

@pcamelo
Copy link

pcamelo commented Nov 29, 2018

+1

@CameronJHall
Copy link

+1 This would be a great feature.

@leonickel
Copy link

+1

3 similar comments
@luchaninov
Copy link

+1

@Asafb26
Copy link

Asafb26 commented Feb 3, 2019

+1

@cdroot92
Copy link

cdroot92 commented Feb 8, 2019

+1

@pjschaafsma
Copy link

In general, the rule should be to not draw attention when no no attention is necessary, or at least allow disabling false positives (something draws attention, when actually everything is fine).

By the way, is this related to the issue where grafana keeps adding green markers to indicate alerts did not fire?

@randybb
Copy link

randybb commented Mar 13, 2019

Probably there could be three visibility options:

  • visible as we see it now,
  • enabled as mark (triangle or arrow) on y axis,
  • hidden.

@pfeerick
Copy link

pfeerick commented Apr 2, 2019

randybb's suggestions are good. I'd also like to see this implemented, as like in dbrgn's example above I am using graphs with multiple sensors (having different ranges), so the display of the warning threshold is just adding visual pollution to the graph.

@blasco991
Copy link

+1

@aharbis
Copy link

aharbis commented Apr 7, 2019

It's also a bit weird that the thresholds are always drawn on the left axis, when the query driving the alert may be targeting the right axis. Example:

image

In this graph, the alert is configured as follows:

WHEN avg() OF query (B, 5m, now) IS ABOVE 60

In this case, B corresponds to the right axis. However, the threshold is drawn on the left axis. Not only is the threshold and color overlay distracting, it's not even an accurate representation of the threshold for the alert.

@stieler-it
Copy link

@aharbis Maybe you should find/open another issue for that one as it is not directly related to this feature request.

@darklow
Copy link

darklow commented May 7, 2019

Alerts - such a great feature, yet enabling them for all charts, makes whole dashboard look like everything is on alert – red overlays on all charts. Hope this could be fixed until end of 2025. Sorry for sarcasm, this would require single checkbox to hide overlay (as there is already heart indicator near chart), yet issue is open for 2+ years :/

@JulesLa
Copy link

JulesLa commented Sep 26, 2019

+1

@macaba
Copy link

macaba commented Oct 14, 2019

+1
Just being able to turn off the fill would suit me.

@rguaitanele
Copy link

+1

5 similar comments
@Marctraider
Copy link

+1

@Samuel29
Copy link

+1

@saxus
Copy link

saxus commented Nov 28, 2019

+1

@lukkigi
Copy link

lukkigi commented Dec 12, 2019

+1

@freedomwarrior
Copy link

+1

@sbarrier
Copy link

It would be nice to have an option like the 'toggle legend', a 'toggle alert' which remove all alert overlays (threshold and annotation) which in some case add to much noise in the graphic.

@epigns
Copy link

epigns commented Jan 15, 2020

It will be really helpful ! +1

@RheaAyase
Copy link

Wew, three years for something that simple and yet so damn important. I better figure out how to hack this myself than waiting for miracle, eh?

@AlexandreGuidin
Copy link

+1

@stingalleman
Copy link

Please..!! Why is this taking so long :(

@dan-bolsun
Copy link

dan-bolsun commented Apr 7, 2020

any updates on this issue?

@armageddon421
Copy link

I would really also like this. For now, I have a separate dashboard with copies of the graphs I want alerts for that I never look at. This means I don't have green hearts on the regular dashboards, but it's still better than all the clutter.

ikkemaniac pushed a commit to ikkemaniac/grafana that referenced this issue May 22, 2020
…efault to 'true' not to break current design. Use newly created alert.line when rendering graph

Should close feature req grafana#7258.
@ikkemaniac
Copy link

What about this? Seems to be working on my end. Can someone else test?

jpalpant added a commit to jpalpant/grafana that referenced this issue Jun 18, 2020
Credit to @ikkemaniac in grafana#25034, but taking this to sign CLA and get it landed. Four commit message were:

- add 'fill' switch on Alert Tab
- add 'fill' to Alert init model. Make default value 'true' not to break current design
- use newly created alert.fill when rendering graph
- add 'line' switch on Alert tab, add 'line' to Alert init model. Set default to 'true' not to break current design. Use newly created alert.line when rendering graph

Should close feature req grafana#7258.
oddlittlebird pushed a commit that referenced this issue Aug 3, 2020
…25705)

* Squash four commits and claim.

Credit to @ikkemaniac in #25034, but taking this to sign CLA and get it landed. Four commit message were:

- add 'fill' switch on Alert Tab
- add 'fill' to Alert init model. Make default value 'true' not to break current design
- use newly created alert.fill when rendering graph
- add 'line' switch on Alert tab, add 'line' to Alert init model. Set default to 'true' not to break current design. Use newly created alert.line when rendering graph

Should close feature req #7258.

* Move alert toggle to Display tab.

* Move alertThreshold to PanelModel.options.

* Fix ThresholdMapper tests by adding options to each mocked panel.

* Update documentation for the new display option.

* Update docs with review feedback.

* Handle onRender with null panel in ThresholdMapper
@stingalleman
Copy link

Awesome, finally! Thank you all so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment