Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Elasticsearch support #5893

Closed
torkelo opened this issue Aug 24, 2016 · 97 comments · Fixed by #11380
Closed

Alerting: Elasticsearch support #5893

torkelo opened this issue Aug 24, 2016 · 97 comments · Fixed by #11380

Comments

@torkelo
Copy link
Member

torkelo commented Aug 24, 2016

Port frontend data source code to backend & Go. Includes building ES query from internal query model, and parsing ES response into time series.

Grafana internal query model example:

Elastic query json model: 
{
  "bucketAggs": [
    {
      "field": "@timestamp",
      "id": "2",
      "settings": {
        "interval": "auto",
        "min_doc_count": 0,
        "trimEdges": 0
      },
      "type": "date_histogram"
    }
  ],
  "dsType": "elasticsearch",
  "metrics": [
    {
      "field": "@value",
      "id": "1",
      "meta": {},
      "settings": {},
      "type": "avg"
    }
  ],
  "refId": "A",
  "target": "",
  "timeField": "@timestamp"
}
@torkelo torkelo added the area/alerting Grafana Alerting label Aug 24, 2016
@bergquist bergquist added this to the 4.0.0-Beta1 milestone Oct 4, 2016
@bergquist bergquist self-assigned this Oct 4, 2016
@bergquist bergquist modified the milestones: 4.1.0, 4.0.0-Beta1 Oct 4, 2016
@bergquist
Copy link
Contributor

ref #5858

@bergquist bergquist removed their assignment Oct 4, 2016
@luigiberrettini
Copy link

Since #5948 is merged is this issue closed?

@bergquist
Copy link
Contributor

@luigiberrettini its not merged to master just to the alerting-elasticsearch branch. It far from completed yet.

@DEvil0000
Copy link

not more far then graphite support ;)
missing graphite query features in alerting:

  • template variables
  • functions referencing other queries (e.g. asPercent)

@ictcorebiz
Copy link

Hi, will complete elasticsearch support come after the 4.0.0 deliverable (planned for November), because I see this issue marked with the 4.1.0 milestone?
If so: when is 4.1.0 planned for delivery?

@torkelo
Copy link
Member Author

torkelo commented Oct 12, 2016

4.1 does not have a release date yet, but would guess January / early feb.

Elasticsearch alerting might not make it into Grafana v4, we tried (the work is started), but requires a lot more work to complete and some more high prio issues has pushed it out of v4

@ictcorebiz
Copy link

In that case, would it be possible to enable/disable the alert-menu items and panel-tabs based on an Organization preference (or even better: on individual user level definitions within the organization)?

@warroyo
Copy link

warroyo commented Dec 7, 2016

Has there been any progress on this? Is the elasticsearch-alerting branch still active? I am wondering if there is something that I could start testing and giving feedback on.

@torkelo torkelo modified the milestones: 4.2.0, 4.1.0 Dec 14, 2016
@xamox
Copy link

xamox commented Jan 13, 2017

Looking forward to this getting into 4.2 so we can fully move to grafana + elasticsearch (metricbeat).

@andytsnowden
Copy link

Having this functionality would be a huge win for my company

@torkelo
Copy link
Member Author

torkelo commented Jan 13, 2017

@andytsnowden enough to buy a support plan? https://grafana.net/support/plans 😜

We hope get a chance to continue work on this soon.

@gbrian
Copy link

gbrian commented Jan 25, 2017

Maybe silly (please don't answer "yes, you are") but what about kind of feature-crowdfunding ? sure many will support

@wirecutter313
Copy link

This was the whole reason I downloaded this tool, in hopes of having alerting for elastic.

@DEvil0000
Copy link

DEvil0000 commented Jan 30, 2017 via email

@yannispanousis
Copy link

yannispanousis commented Feb 2, 2017

Is there a strong chance this is going to make the 4.2.0 mark? Trying to come up with temporary alternatives for the alerting part while we wait for this.

@torkelo
Copy link
Member Author

torkelo commented Feb 2, 2017

its not looking like that. No one is working on it that we know and we have a lot on our plate right now.

@mizalewski
Copy link

@nikskiz Grafana is open source project, and everyone can contribute to it. Also you can contribute!

Many people work on open source projects for free in their free time, and I think it is not ok to be rude and criticize their work.

@javasoze
Copy link

There is a smaller PR in progress: wph95#2 by @wph95

@4ndv
Copy link

4ndv commented Mar 24, 2018

@nikskiz right now you can use influxdb

@kvalev
Copy link

kvalev commented Mar 24, 2018

@nikskiz or you can simply use elastalert

@lucasrodcosta
Copy link
Contributor

lucasrodcosta commented Mar 25, 2018

Hi everyone!

We all know that alerting for Elasticsearch is an amazing, very-welcome and long-waited feature.
But I think we should keep this thread as clean and organized as possible.

So, questions and comments like these...

Any timeline?
It would be very useful!
Can't wait for it!
Has there been any progress on this?

doesn't help in evolution of the feature, generates a lot of useless emails to people who subscribed to the thread and makes the discussion too much confusing to new participants.

Even questions about workarounds and other alerting solutions (like ElastAlert) shouldn't been posted here anymore, as it has already discussed a lot in previous comments.

So, please, stop trivializing this space! Let's use them to spread useful comments and to share the progress you've made on this feature.

@wph95
Copy link
Contributor

wph95 commented Mar 26, 2018

I just finished a PR #11380 to make grafana support Alerting [Elasticsearch]

Compared to some early implementations e.g. #8943 , #10343

  • base on grafana-5.0.0
  • source code less than 1000 lines (and a third lib [leibowitz/moment]~=1000 line, and some test code)
  • Code logic is consistent with the front

this week i will continue to improve this PR, more comprehensive test, clearer abstract model.
I'm looking forward to someone who can try to use this PR and improve it :)

@harshvladha
Copy link

@wph95 - I will be trying your PR this week for sure, will create issue in your repo, if that's ok with you, and look into contributing there.

@Guchman
Copy link

Guchman commented Apr 26, 2018

Merge that already please. Thats a hot feature.

@yossiv
Copy link

yossiv commented Apr 27, 2018

anything we can help in order to promote this ?

@i033653
Copy link

i033653 commented Apr 27, 2018

What is the estimation to merge it? Shall I wait or use X-Pack?

@jockjiang
Copy link

+1, What is the estimation to merge it? 5.2.x?

@yossiv
Copy link

yossiv commented May 12, 2018

Hi i know we pushing you too much on this , but this issue was open almost 2 years ago (Aug2016) .
elasticsearch + Grafana commutiy is wide and big like others i guess.
i really appreciate the great job this community doing for us, but seems like this issue stayed behind :(
is there anything we can do in order to promote this?

@demetriusnunes
Copy link

Why is it taking so long to merge the PR?

@marefr marefr self-assigned this May 15, 2018
@enigy
Copy link

enigy commented May 18, 2018

+1

2 similar comments
@futurpc
Copy link

futurpc commented May 18, 2018

+1

@petrochen
Copy link

+1

@beriba
Copy link

beriba commented May 19, 2018

Stop writing comments with only "+1" because you're spamming other people. You're not adding anything to the topic. Click thumbs up button on the main post or click Subscribe button instead.

@guohailong2006
Copy link

+1

@Trainxy
Copy link

Trainxy commented May 29, 2018

+1

@marefr marefr added this to the 5.2 milestone May 31, 2018
marefr added a commit that referenced this issue Jun 1, 2018
@ldktta
Copy link

ldktta commented Jun 4, 2018

🎉 🎉 🎉 💖

@mvlach
Copy link

mvlach commented Jun 4, 2018

🎉

@xamox
Copy link

xamox commented Jun 4, 2018

Wow, it happened. I honestly thought this was going to go the way of duke nukem. 👍

@dev-e
Copy link

dev-e commented Jun 28, 2018

Thanks a lot for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.