Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Service Discovery via LabelSelector #691

Open
msvechla opened this issue Mar 20, 2024 · 0 comments
Open

Kubernetes Service Discovery via LabelSelector #691

msvechla opened this issue Mar 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@msvechla
Copy link
Contributor

Hello and thanks for this awesome project!

We want to deploy beyla to our environments, however for us the current service discovery mechanism is not working.
In Kubernetes a common way to select services is via labels. This is how usually other operator or controllers select applicable workloads.

Would it be possible to add a label selector to the Kubernetes service discovery mechanism?
I would also be willing to contribute a PR.

Using the current structure would only allow a hack of adding a single regexp matcher on the entire labels of a pod, as the processAttrs.metadata only allows a map[string]string{}.

So we probably would have to add a new config structure to accommodate a label selector.

Another question would be if it should be an actual label selector (meaning we will use this also for filtering out pods directly from the Kube api server), or if it will be a simple regexp match on the pod labels, same as we already do with the other Kubernetes metadata attributes.

What are your thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants