Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”§ [Refactor] Loginserver is not recompiled after update #79

Closed
ulfgebhardt opened this issue Mar 24, 2021 · 1 comment Β· Fixed by #103
Closed

πŸ”§ [Refactor] Loginserver is not recompiled after update #79

ulfgebhardt opened this issue Mar 24, 2021 · 1 comment Β· Fixed by #103

Comments

@ulfgebhardt
Copy link
Contributor

⚑ Refactor ticket

Loginserver is not recompiled after update when run in docker
docker-compose up is not sufficient to make sure the latest version of the loginserver is compiled. docker-compose up --build does whats needed but takes 30mins. So we need to make sure the loginserver is only compiled (fully) when the code changed.

@einhornimmond
Copy link
Member

"True, docker-compose up never rebuilds an image. This is "intended", but it's something I think we should change: #693

You can run docker-compose build to build the images."
Source: docker/compose#1487

Does that mean I must rebuild login-server after starting the docker-image, also with CMD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
πŸ“” Gradido
Awaiting triage
Development

Successfully merging a pull request may close this issue.

2 participants