Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary files fail on forked repositories #81

Open
pelikhan opened this issue Feb 9, 2022 · 5 comments · Fixed by #84
Open

Binary files fail on forked repositories #81

pelikhan opened this issue Feb 9, 2022 · 5 comments · Fixed by #84
Labels

Comments

@pelikhan
Copy link
Contributor

pelikhan commented Feb 9, 2022

When trying to create a commit with a binary file (e.g. image), this request fails with a 404 on a forked scenario (user does not have rights to push to repo).

Is it the case that it should be owner: fork instead of owner ?

anandchakru added a commit to anandchakru/octokit-plugin-create-pull-request that referenced this issue Mar 2, 2022
anandchakru added a commit to anandchakru/octokit-plugin-create-pull-request that referenced this issue Mar 2, 2022
@gr2m gr2m closed this as completed in #84 Mar 3, 2022
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

🎉 This issue has been resolved in version 3.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pelikhan
Copy link
Contributor Author

pelikhan commented Mar 8, 2022

Looks like my fix was half busted so probably reopen this @gr2m

@gr2m gr2m reopened this Mar 8, 2022
@gr2m
Copy link
Owner

gr2m commented Mar 8, 2022

Are you working on a follow up pull request?

@pelikhan
Copy link
Contributor Author

pelikhan commented Mar 8, 2022

I wonder if this should not be state.fork as well

@pelikhan
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants