Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @octokit/core as peerDependency #58

Open
gr2m opened this issue Aug 26, 2020 · 0 comments
Open

Add @octokit/core as peerDependency #58

gr2m opened this issue Aug 26, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gr2m
Copy link
Owner

gr2m commented Aug 26, 2020

This is a follow up issue to octokit/plugin-paginate-rest.js#124 (comment)

We need to add @octokit/core as a peerDependency to address a problem with yarn 2. It is something I planned to do anyway, but wanted to figure out automated testing to assure compatibility of the plugins with the latest @octokit/core.

I only want to define compatibility with the lowest version, in this case v3. Compare pull request https://github.com/octokit/plugin-paginate-rest.js/pull/130/files.

I would appreciate help, this is a great issue for a first-time contributor

@gr2m gr2m added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant