Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable the fork behaviour #46

Open
LucaLanziani opened this issue Jun 18, 2020 · 3 comments
Open

Option to disable the fork behaviour #46

LucaLanziani opened this issue Jun 18, 2020 · 3 comments

Comments

@LucaLanziani
Copy link
Contributor

I'm using the library from a CI server to generate multiple files in the organization.
The CI is using the credential of a ci github user that is not part of the organization and I add this user as collaborator when it needs access to a specific repo.

The preferred behavior in this situation is to fail in case the user doesn't have push permission to the repo and not to fork it since no one will have access to this fork if not an admin.
Moreover the CI user might end up having many of the repos forked.

@gr2m
Copy link
Owner

gr2m commented Jun 18, 2020

Why would you have the CI user try to update files if it does not have the permission to do so?

@LucaLanziani
Copy link
Contributor Author

A simple error in the configuration can cause that.
One person adds a new feature to the CI job to open a PR on repo xyz thinking permissions are ok while they are not.

Obviously I can catch this case before calling the createPullRequest if you prefer not to change the plugin behavior.

@gr2m
Copy link
Owner

gr2m commented Jun 18, 2020

I'd suggest you do that for the time being, I'd want to implement it for your case alone, it's too uncommon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants