You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
internal_devices.TimeOfDay offers a non-timezone-aware interface. datetime.utcnow() which is used in value is deprecated from Python3.12 onwards with a rationale to improving timezone awareness and handling in the wider codebase.
Doing anything other than filtering this is potentially dangerous. In my opinion, we should look to update TimeOfDay:
to offer a TimeZone aware interface, including a UTC option (e.g. adding a timezone keyword which defaults to local timezone)
raise DeprecationWarnings ourselves for those using the current naive option (utc=True)
then later remove the naive option as it provides hobby programmers with a high-potential source of error.
Adding a timezone-aware recipe or two would definitely be a good idea when doing this.
For now I have filtered out the Deprecation Warning with PR #1112
The text was updated successfully, but these errors were encountered:
internal_devices.TimeOfDay
offers a non-timezone-aware interface.datetime.utcnow()
which is used invalue
is deprecated from Python3.12 onwards with a rationale to improving timezone awareness and handling in the wider codebase.Doing anything other than filtering this is potentially dangerous. In my opinion, we should look to update
TimeOfDay
:timezone
keyword which defaults to local timezone)utc=True
)For now I have filtered out the Deprecation Warning with PR #1112
The text was updated successfully, but these errors were encountered: