Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncvg: block size appears to be ignored for pixel data #2707

Open
3 tasks done
bradh opened this issue Dec 24, 2023 · 0 comments
Open
3 tasks done

uncvg: block size appears to be ignored for pixel data #2707

bradh opened this issue Dec 24, 2023 · 0 comments

Comments

@bradh
Copy link
Contributor

bradh commented Dec 24, 2023

Thanks for reporting your issue. Please make sure these boxes are checked before submitting your issue - thank you!

Detailed guidelines: https://gpac.io/bug-reporting/

Running uncvg with block does not produce the expected padding bits.

In my testing with:
uncvg:sq=1:vsize=30x20:tiles=1x1:c=R8,G8,B8:sampling=none:interleave=pix:block_size=4:pixel_size=0:row_align=0:tile_align=0:fps=0

I see the resulting file contains:

0000500 83 84 00 00 07 38 6d 64 61 74 ff 00 00 ff 00 00  >.....8mdat......<
0000520 ff 00 00 ff 00 00 00 80 00 00 80 00 00 80 00 00  >................<
0000540 80 00 00 00 ff 00 00 ff 00 00 ff 00 00 ff ff ff  >................<

Those 0xff after the start of mdat correspond to red values, and they occur every three bytes. Comparing that to Figure 12 (or Figure 13 for the storage view) in the FDIS, I would expect every four bytes.

Possibly related: When I view the resulting file in gpac -gui, I see corruption on the right pixels:

image

The effect is more visible if using tiles, as in:
uncvg:sq=1:vsize=30x20:tiles=2x4:c=R8,G8,B8:sampling=none:interleave=pix:block_size=4:pixel_size=0:row_align=0:tile_align=0:fps=0

where the first tile looks OK, but then its corrupted:

image

I don't see that visual corruption with block_size=0.

@bradh bradh changed the title uncvg: block size appears to be ignored uncvg: block size appears to be ignored for pixel data Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant