Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Link list compatibility with react-router-dom@5.1 #892

Open
4 tasks done
quoclieusecurityshift opened this issue Nov 24, 2019 · 2 comments
Open
4 tasks done

Link list compatibility with react-router-dom@5.1 #892

quoclieusecurityshift opened this issue Nov 24, 2019 · 2 comments
Labels
🐛 bug Something isn’t working the way it should.

Comments

@quoclieusecurityshift
Copy link

Feature Request

  • I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
  • I’ve read and agree to the Code of Conduct.
  • I’ve searched for any related issues and avoided creating a duplicate issue.
  • I've searched the community forums to check for related issues or feature requests

Is this feature request relating to an existing component? Please describe.

  • Component name: link-list
  • Component version: 3.0.8

Make the link-list component compatible with react-router-dom ver 5.1 and up - specifically with the new Link component. At the moment link-list only works with the Link component that is version 5.0.1 and below. Our project is looking to use some of the new react-router-dom features found in 5.1 but is currently stuck using 5.0.1 due to this issue.

Do you have a suggestion for a new component?

Remove/change the check for if linkComponent is a function. react-router-dom@5.1 Link component seems to be a context object.

// REMOVE THIS
 else if( typeof LinkComponent === 'function' ) {
	attributeOptions.to = link;
}

Ideally this would be changed in the header and footer components as well.

@gordongrace
Copy link
Contributor

gordongrace commented Nov 24, 2019

Really good suggestion, @quoclieusecurityshift . We've been able to reproduce this on the components you've mentioned. This appears to be a fairly easy fix to a foundational issue.

Thanks for taking the time to report the issue.

@gordongrace gordongrace added the 🐛 bug Something isn’t working the way it should. label Nov 24, 2019
@gordongrace gordongrace added this to 🌱 Product Backlog in Design System via automation Nov 24, 2019
@qfz
Copy link

qfz commented Nov 26, 2019

FYI @quoclieusecurityshift and I work in the same team and there's a PR (#891) for this issue. I submitted the PR right before I went on a week-long leave and forgot to let Quoc know.

@KiriHoy KiriHoy moved this from 🌱 Product Backlog to ✏️ Sprint backlog in Design System Nov 26, 2019
@anthonymckerron anthonymckerron moved this from ✏️ Sprint backlog to 🌱 Product Backlog in Design System Dec 19, 2019
@anthonymckerron anthonymckerron removed their assignment Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn’t working the way it should.
Projects
Design System
  
🌱 Product Backlog
Development

No branches or pull requests

4 participants