Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple POST calls should only create 1 entry for applications #572

Open
Ultimatum22 opened this issue Jun 12, 2023 · 1 comment
Open
Labels
a:feature New feature or request

Comments

@Ultimatum22
Copy link

Is your feature request related to a problem? Please describe.
When using the API it is possible to add duplicate entries. For example, I use this to populate the server with default applications when installing with Ansible.

Describe the solution you'd like
If you use the API to create an application and the name already exists it should throw a 400 bad request.

Describe alternatives you've considered
Another option is to read the GET application and then check if the application is already present but that is too much of a hassle.

Additional context
This issue could be for more API calls, I haven't checked it because I am only using the application endpoint.

Are you open for a PR if this is a good feature, it's not that difficult to implement.

@Ultimatum22 Ultimatum22 added the a:feature New feature or request label Jun 12, 2023
@jmattheis
Copy link
Member

Hmm, I'm not sure. There can be valid use-cases for applications with the same name.

The client api functions similar, but it's required to work that way, because for most clients a more or less static client identifier (user-agent or device manufacturer) is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature New feature or request
Development

No branches or pull requests

2 participants