Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: option to send certificate for NGINX ssl client verification #85

Open
renehonig opened this issue Nov 8, 2019 · 6 comments · May be fixed by #344
Open

feature request: option to send certificate for NGINX ssl client verification #85

renehonig opened this issue Nov 8, 2019 · 6 comments · May be fixed by #344
Labels
a:feature New feature or request help wanted Extra attention is needed

Comments

@renehonig
Copy link

I am using Gotify in combination with NGINX (based on the example configuration script). I would like to use the NGINX ssl client verification option (syntax: ssl_client_certificate file; ssl_verify_client on), which would require the Gotify app to send a pre-configured client certificate. Could this feature be added, or is there another/better way to do this?

@renehonig renehonig changed the title feature request: option to send client certificate for NGINX authentication feature request: option to send certificate for NGINX ssl client verification Nov 8, 2019
@jmattheis jmattheis added a:feature New feature or request help wanted Extra attention is needed labels Nov 9, 2019
@jmattheis
Copy link
Member

Yeah, this could be done.

@MoonCactus
Copy link

MoonCactus commented Jan 11, 2021

I suspect my problem is identical

  • I use the docker version of gotify server (Gotify version 2.0.21@2021-01-06-15:38:32), latest from yesterday
  • it is set up as a local HTTP service
  • I use nginx as a proxy (enventually with the provided config example as well, my early tests were no better)
  • I use an external https://push.mydomain.com URL with a letsencrypt certificate
  • The web UI works well (when I publish with curl or gotify CLI I do get the notification in my browser and desktop popup)
  • The prebuilt android client does log in correctly to the server

Though I can see client's calls to the docker server like DELETE "/message", the android client never shows any notifcation.

I am not sure how to investigate further (eg. which logfiles in the docker, or how to check if the websocket is working?)

@jmattheis
Copy link
Member

@MoonCactus have you tried sending a message with a higher priority? See https://github.com/gotify/android#message-priorities
If this doesn't work please create a new issue.

@MoonCactus
Copy link

MoonCactus commented Jan 11, 2021

Thanks, yes! curl 'https://push.mydomin.com/message?token=my_token" -F "title=from_pc" -F "message=msg from $(hostname)" -F "priority=9"

@MoonCactus
Copy link

(actually, the more I think about it the more I think I am polluting the initial report anyway, sorry!)

@MoonCactus
Copy link

PEBCAC? Today I deleted all my users all the app tokens, then created them again from scratch -- and it worked immediately.

I also was not able to reproduce the problem! Just in case you wanted to know or it happended again: I was properly logged with the same user on the desktop and on the smartphone. When I posted a notification with curl, I was notified on the desktop, but never on the smartphone. I checked that the websockets were established on the server, and the log in the smartphone app showed no error either. It may be that I deleted/re-created the tokens more than once.

Note that this probably does not close the original FR though -- I was offtopic, sorry again for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature New feature or request help wanted Extra attention is needed
Development

Successfully merging a pull request may close this issue.

3 participants