Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add a custom LargeIcon for notification #256

Open
Paolo7297 opened this issue Nov 28, 2022 · 7 comments
Open

Feature Request: add a custom LargeIcon for notification #256

Paolo7297 opened this issue Nov 28, 2022 · 7 comments
Labels
a:feature New feature or request request-for-comments

Comments

@Paolo7297
Copy link

It would be nice to have another field inside client::notification, maybe called imageUrl to set a custom LargeIcon (the one inline with the text in the notification).

@jmattheis
Copy link
Member

I don't know if this is really needed, as you can already add custom image via Markdown. I'd be open to wait for feedback from other users.

@jmattheis jmattheis added a:feature New feature or request request-for-comments labels Nov 29, 2022
@Paolo7297
Copy link
Author

Sorry for the stupid question, but how can I replace the LargeIcon (so the one which is inline with the text) with markdown? I already tried to add image in markdown , but it's only available on web ui, on android is rendered as a small block with "obj" text inside.

I know there's bigImageUrl, but the image covers half of the screen, instead having inline with the text would be much more clear.

@jmattheis
Copy link
Member

What do you mean with large icon, the image left to the text of the message content? What's the markdown image url that doesn't work on the android app but on the webui?

@Paolo7297
Copy link
Author

Yes, this one. You set in the notification using the setLargeIcon method.

I just tried with https://placekitten.com/400/300 with the same result as images in my webserver.

@jmattheis
Copy link
Member

You can change the image globally for all messages from an application, but for a single message you cannot override it. You can embed the image with markdown into the message like this (using placekitten):

image

@Paolo7297
Copy link
Author

Yes, that's why I'm asking for a feature to override it.

@jmattheis
Copy link
Member

Yes, I understand this, but as said in my first comment, I think it not a feature that is needed by many users, so let's wait for comments from other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature New feature or request request-for-comments
Development

No branches or pull requests

2 participants