Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade all profiles ability #270

Closed
BlackBaroness opened this issue Jan 21, 2023 · 6 comments · May be fixed by #277
Closed

Upgrade all profiles ability #270

BlackBaroness opened this issue Jan 21, 2023 · 6 comments · May be fixed by #277
Labels
enhancement Improvements to the project

Comments

@BlackBaroness
Copy link

The problem

Currently we can't just update all mods inside all profiles that can be important for someone (it is for me).

My solutions

Add a command such a ferium upgrade --all-profiles to run upgrade for all profiles.
@BlackBaroness BlackBaroness added the enhancement Improvements to the project label Jan 21, 2023
@logistic-bot
Copy link

I will try to do this.

logistic-bot added a commit to logistic-bot/ferium that referenced this issue Feb 14, 2023
@logistic-bot
Add ability to upgrade the mods of all profiles
049e6d9 
Closes gorilla-devs#270

Also added an indicator to show which profile is currently being worked
on. This is currently shown even if only one profile is being update
@logistic-bot logistic-bot mentioned this issue Feb 14, 2023
Open
@theRookieCoder
Copy link
Collaborator

The PR got me thinking, how should this be implemented? Should it upgrade each profile separately or should all the profiles be upgraded at once? (I prefer the latter)

@BlackBaroness
Copy link
Author

The PR got me thinking, how should this be implemented? Should it upgrade each profile separately or should all the profiles be upgraded at once? (I prefer the latter)

I don't know exactly how the architecture of this application is structured. But I imagine something like this:

for (profile : profiles) {
    profile.upgrade()
}

I think it's probably best to just run upgrade for each profile separately. I tried to do this with a bash script, but the parsing turned out to be too complicated.

(Just looked at PR and it's exactly as I imagined)

Updating all profiles at the same time will require too much code change, it seems to me that this option would still be more correct.

@logistic-bot
Copy link

Updating all profiles at the same time will require too much code change
I don't feel confident enough to change the code so that all profiles get updated at the same time.

@theRookieCoder
Copy link
Collaborator

I think this can go under #163

@theRookieCoder theRookieCoder closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2023
@theRookieCoder
Copy link
Collaborator

Basically you would be able to do ferium upgrade --profile *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvements to the project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to upgrade the mods of all profiles logistic-bot/ferium
3 participants
@logistic-bot @BlackBaroness @theRookieCoder