Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onPress visual feedback for tab items (RawButton) #79

Open
BenJeau opened this issue Sep 25, 2020 · 0 comments · May be fixed by #94
Open

Add onPress visual feedback for tab items (RawButton) #79

BenJeau opened this issue Sep 25, 2020 · 0 comments · May be fixed by #94
Labels
enhancement New feature or request

Comments

@BenJeau
Copy link

BenJeau commented Sep 25, 2020

Feature Request

When pressing a tab item, there is no immediate visible feedback to the user. Making the tab item have a ripple effect (for android), a opacity change (for iOS), or something more custom would be great!

Why it is needed

For the user to have a more smooth animated experience.

Possible implementation

Not exactly sure, but I think <RawButton /> would need to be modified. Maybe somehow integrating a <Pressable /> (https://reactnative.dev/docs/pressable) or a touchable (https://docs.swmansion.com/react-native-gesture-handler/docs/component-touchables)? @gorhom if you have an idea how to implement this, please let me know since I'm not sure and I would like to open a PR implementing it (but I don't have a lot of experience with animated stuff), unless you would like to do it.

Code sample

Not sure yet

@BenJeau BenJeau added the enhancement New feature or request label Sep 25, 2020
@BenJeau BenJeau linked a pull request Dec 20, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant