[FINISHED] Feature Freeze - March 2023 #13075
ZeWaka
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello all, we'll be having a spring 🧊feature freeze🧊 in March. This will be just like the last one - essentially, you won't be able to PR new features during the period this time.
This Feature Freeze will start on March 1st, 2023 and end on March 31st, 2023.
Q: What is a feature freeze?
We will generally not be merging or allowing any new feature PRs during the time period.
Q: Why?
New features are the number one cause of bugs and instability in the codebase. The goal during this time is to fix a lot of these bugs and get through existing PRs. This allows us to clean up the reviewing queue so we can look at your PRs quicker in the future. Some of us also want to work on larger projects and cleanup initiatives. It's also just a bit of a break.
Q: What if I submit a feature PR before the freeze but it isn't merged by the deadline?
That's fair game to be potentially merged during the freeze. This does not mean that we will merge them though - PR merges are always up to Developer discretion.
Q: What about refactors?
While refactors are generally extremely good for code cleanliness, they can contribute instability to the codebase, especially when first done. Furthermore, they could conflict with other refactors that people are working on. Of course, if you get permission then it's OK.
As always, it is suggested to ask a Developer first before working on/submitting a PR that refactors a game system.
Q: What about bugfixes?
Bugfixes will be merged as normal. Please link them to an associated issue filed on the GitHub.
However, this is not free reign to package new features and bugfixes in the same PR. We still want PRs to be properly split up into smaller PRs and not have parts combined.
Exceptions may be made if a small feature is added to fix a bug.
Q: What about balance changes?
If the balance change is just changing a number or doing a similar trivial change, then it's fine as long as we think it couldn't introduce new bugs. A balance change that adds new functionality won't be accepted.
Q: What about sprite/map changes?
For sprite changes: these are fine if it's a simple icon-state replace or similar. Big DMI modifications not so much.
For map changes: generally not fine unless it's explicitly a bugfix or a developer-sponsored rework of some kind.
Feel free to ask me if you have any specific questions that aren't answered here.
Beta Was this translation helpful? Give feedback.
All reactions