Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not set a default storagePath? #217

Open
Lqingyu opened this issue Jun 27, 2021 · 1 comment
Open

Why not set a default storagePath? #217

Lqingyu opened this issue Jun 27, 2021 · 1 comment

Comments

@Lqingyu
Copy link

Lqingyu commented Jun 27, 2021

No description provided.

@saelo
Copy link
Collaborator

saelo commented Jun 28, 2021

So I guess there are at least two issues with that:

  • What to do if the directory already exists? Should one of --resume or --overwrite be the default as well (probably not --overwrite?) or do we just error out here in that case
  • Workers don't use a storagePath:
    --container-arg="sysctl -w 'kernel.core_pattern=|/bin/false' && ./Fuzzilli --logLevel=warning --jobs=$NUM_WORKERS_PER_MACHINE --networkWorker=$master_ip:1337 $FUZZILLI_ARGS $BINARY" \

That said, maybe we could add an explicit --no-storage flag or something like that, or we could turn this line

logger.warning("No filesystem storage configured, found crashes will be discarded!")
into a fatal error, so I'm open to suggestions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants