Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maps.Client Automatic Retry? Exponential Backoff? #268

Open
danjacques opened this issue Jun 18, 2022 · 1 comment
Open

maps.Client Automatic Retry? Exponential Backoff? #268

danjacques opened this issue Jun 18, 2022 · 1 comment
Assignees
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@danjacques
Copy link

The documentation for Maps API client suggests that each API client automatically handles retry on transient failure:

Retry on Failure The client libraries will automatically retry any request if the API sends a 5xx error.
Retries use exponential back-off, which helps in the event of intermittent failures.

image

However, looking at the code for maps.Client, Maps API methods look like they ultimately boil down to do(), which in turn defers to http.Client's Do() method. This does not perform any retry or backoff in the default HTTP client.

Is this a library bug or a documentation error, or am I missing something obvious? If one of the former, is there any formal guidance on best practices to perform retry/backoff with a maps.Client? Thanks!

@danjacques danjacques added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 18, 2022
@emanuelmendezpeya
Copy link

Hello, is this going to be addressed? We're having timeout errors in our service and a retry with exponential back-off would help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants