Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KML Layer loading KMZ file should load icons included in it #716

Open
chitgoks opened this issue May 11, 2020 · 12 comments
Open

KML Layer loading KMZ file should load icons included in it #716

chitgoks opened this issue May 11, 2020 · 12 comments
Labels
triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@chitgoks
Copy link

Please see attached kmz file. the icon should be loaded as well.

please rename to .kmz

track.zip

@chitgoks chitgoks added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 11, 2020
@ryust
Copy link

ryust commented Jun 17, 2020

I've had a similar issue where a KML file has defined icons for placemarks, but the default icon briefly shows and then is replaced with the one specified in the file. The default should never show. On Google Earth it displays as expected, while the KmlLayer in the library doesn't match rendering.

I don't consider this a feature as much as an unexpected bug. See the attached sample.

MO Delorme.kml.zip

@chitgoks
Copy link
Author

chitgoks commented Sep 2, 2020

another sample. rename to .kmz
KmlFeatureParser should probably do a trim() to be sure and a check perhaps if the value is empty or not? else Integer.parseInt will also return an error

line 136-137
} else if (parser.getName().equals("visibility")) {
                    visibility = Integer.parseInt(parser.nextText());

the sample kmz file returns

 Caused by: java.lang.NumberFormatException: For input string: "
    1
    "

sample.zip

@stale
Copy link

stale bot commented Dec 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

@stale stale bot added the stale label Dec 31, 2020
@chitgoks
Copy link
Author

up

@stale stale bot removed the stale label Dec 31, 2020
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

@stale stale bot added the stale label Jun 2, 2021
@chitgoks
Copy link
Author

chitgoks commented Jun 2, 2021

valis

@stale stale bot removed the stale label Jun 2, 2021
@stale
Copy link

stale bot commented Oct 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

@stale stale bot added the stale label Oct 2, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

Closing this. Please reopen if you believe it should be addressed. Thank you for your contribution.

@stale stale bot closed this as completed Apr 16, 2022
@chitgoks
Copy link
Author

urgent! how to reopen?!?

@barbeau barbeau reopened this Apr 16, 2022
@stale stale bot removed the stale label Apr 16, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

@stale stale bot added the stale label Sep 21, 2022
@chitgoks
Copy link
Author

Please re-open

@stale stale bot removed the stale label Jan 24, 2023
@ryust
Copy link

ryust commented May 2, 2023

In case the stale bot wants to interfere again... this hasn't been fixed and needs to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants