Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Radius required, use Black as colour in Circle #531

Open
lucanicoletti opened this issue Mar 5, 2024 · 2 comments
Open

Make Radius required, use Black as colour in Circle #531

lucanicoletti opened this issue Mar 5, 2024 · 2 comments
Labels
triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@lucanicoletti
Copy link

Both Polygon and Polyline use Black as the default colour, making them visible on the Map when used without specifying a colour.
Circle by default draws a 0-radius circle. If the radius is specified, it still draws a Transparent circle on the map, making it not visible.
Update the Circle function to require the radius to be specified, and change the default colour to Color.Black, as used in other Composable for Maps.
As it was a simple edit, I've done it already and I would be ready to open the PR if this is agreed upon

@lucanicoletti lucanicoletti added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 5, 2024
@wangela
Copy link
Member

wangela commented Mar 5, 2024

If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

@lnicolet Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@lucanicoletti
Copy link
Author

Is there any update on this? I'm happy to make the changes and open a PR request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants