Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default expressions on optional parameters are not public #513

Open
bubenheimer opened this issue Jan 28, 2024 · 0 comments · May be fixed by #514
Open

Default expressions on optional parameters are not public #513

bubenheimer opened this issue Jan 28, 2024 · 0 comments · May be fixed by #514
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bubenheimer
Copy link
Contributor

android-maps-compose 4.3.2

The GoogleMap() compose function uses certain default expressions on optional parameters that are not public. This prevents overriding the function in app code in a reasonable manner.

This is what the "API Guidelines for @composable components in Jetpack Compose" have to say on it:

Developers should make sure that default expressions on optional parameters are publicly available and meaningful.

https://github.com/androidx/androidx/blob/androidx-main/compose/docs/compose-component-api-guidelines.md#default-expressions
@bubenheimer bubenheimer added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 28, 2024
bubenheimer added a commit to bubenheimer/android-maps-compose that referenced this issue Jan 28, 2024
@bubenheimer
fix: make DefaultMapProperties, DefaultMapUiSettings, and NoPadding p…
7b29de1 
…ublic

Fixes googlemaps#513
@bubenheimer bubenheimer linked a pull request Jan 28, 2024 that will close this issue
Open
bubenheimer added a commit to bubenheimer/android-maps-compose that referenced this issue Apr 23, 2024
@bubenheimer
fix: make DefaultMapProperties, DefaultMapUiSettings, and NoPadding p…
f13b2c7 
…ublic

Fixes googlemaps#513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@bubenheimer