Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Cloud Deploy: Deploy Parameters #181

Closed
markmandel opened this issue Jul 17, 2023 · 0 comments · Fixed by #260
Closed

Google Cloud Deploy: Deploy Parameters #181

markmandel opened this issue Jul 17, 2023 · 0 comments · Fixed by #260
Assignees
@markmandel
Labels
enhancement New feature or request

Comments

@markmandel
Copy link
Member

Deploy Parameters just dropped as Preview for Cloud Deploy!

We should look at if/where we can replace some of the Terraform generation code with deploy parameters (I think we can remove a chunk of it - not sure about all, but definitely some).

https://cloud.google.com/deploy/docs/deploy-app-parameters
https://cloud.google.com/deploy/docs/parameters
@markmandel markmandel added the enhancement New feature or request label Jul 17, 2023
@markmandel markmandel mentioned this issue Sep 14, 2023
Open
@markmandel markmandel self-assigned this Feb 14, 2024
markmandel added a commit to markmandel/global-multiplayer-demo that referenced this issue Feb 16, 2024
@markmandel
Move Profile Service to Cloud Deploy Parameters
e54b3cf 
Starting the work to move our Service Cloud Deploy configuration away
from files generated from Terraform, to using Cloud Deploy Parameters!

So the Teraform now stores the required information on the Cloud Deploy
Pipeline that needs to be used in Parameters - and Cloud Deploy handles
the rest! It's pretty straight forward, and requires minimal code
changes.

Included some other minor tweaks:
* Switch to use a script step.
* Formatted the cloud build script
* Needed to upgrade the Google Cloud Terraform module

More services coming!

Work on googleforgames#181
markmandel added a commit to markmandel/global-multiplayer-demo that referenced this issue Feb 16, 2024
@markmandel
Move Profile Service to Cloud Deploy Parameters
b97556a 
Starting the work to move our Service Cloud Deploy configuration away
from files generated from Terraform, to using Cloud Deploy Parameters!

So the Teraform now stores the required information on the Cloud Deploy
Pipeline that needs to be used in Parameters - and Cloud Deploy handles
the rest! It's pretty straight forward, and requires minimal code
changes.

Included some other minor tweaks:
* Switch to use a script step.
* Formatted the cloud build script
* Needed to upgrade the Google Cloud Terraform module

More services coming!

Work on googleforgames#181
@markmandel markmandel mentioned this issue Feb 16, 2024
Merged
markmandel added a commit that referenced this issue Feb 21, 2024
@markmandel
Move Profile Service to Cloud Deploy Parameters (#236)
ec767d1 
Starting the work to move our Service Cloud Deploy configuration away
from files generated from Terraform, to using Cloud Deploy Parameters!

So the Teraform now stores the required information on the Cloud Deploy
Pipeline that needs to be used in Parameters - and Cloud Deploy handles
the rest! It's pretty straight forward, and requires minimal code
changes.

Included some other minor tweaks:
* Switch to use a script step.
* Formatted the cloud build script
* Needed to upgrade the Google Cloud Terraform module

More services coming!

Work on #181
markmandel added a commit to markmandel/global-multiplayer-demo that referenced this issue Mar 11, 2024
@markmandel
Migration of service to Cloud Deploy Params
87d093d 
This finishes the migration of all the services to use Cloud Deploy
params rather than generating configuration files locally.

Work on googleforgames#181
@markmandel markmandel mentioned this issue Mar 11, 2024
Merged
markmandel added a commit that referenced this issue Mar 11, 2024
@markmandel
Migration of service to Cloud Deploy Params (#238)
86efe95 
This finishes the migration of all the services to use Cloud Deploy
params rather than generating configuration files locally.

Work on #181
markmandel added a commit to markmandel/global-multiplayer-demo that referenced this issue Mar 12, 2024
@markmandel
Move liquidbase.properties off local machine.
4e29e93 
This moves the liquidbase.properties file into a GCS bucket, so it's
referencable from the Cloud Build script that does the Spanner schema
migration.

This moves the file off the local file system, which is a pre-requisite
work for googleforgames#192, and should also be done before marking googleforgames#181 as complete.
@markmandel markmandel mentioned this issue Mar 12, 2024
Merged
markmandel added a commit that referenced this issue Mar 12, 2024
@markmandel
Move liquidbase.properties off local machine. (#239)
44b11fb 
This moves the liquidbase.properties file into a GCS bucket, so it's
referencable from the Cloud Build script that does the Spanner schema
migration.

This moves the file off the local file system, which is a pre-requisite
work for #192, and should also be done before marking #181 as complete.
markmandel added a commit to markmandel/global-multiplayer-demo that referenced this issue Apr 24, 2024
@markmandel
Move Platform/Open Match to Cloud Deploy Params
aee2765 
This was a fun one as we have a Helm chart in play, and that was
non-obvious in terms of how to integrate:

* Remove `kustomize` render, since we don't need it anymore.
* Create Cloud Parameters that match the Helm configuration variables
  that we need to match in the Helm configuration.
* Also moved cloudbuild.yaml to `script:`

Next is the Agones deployments!

Work on googleforgames#181
@markmandel markmandel mentioned this issue Apr 24, 2024
Merged
markmandel added a commit to markmandel/global-multiplayer-demo that referenced this issue Apr 24, 2024
@markmandel
Move Platform/Open Match to Cloud Deploy Params
e786830 
This was a fun one as we have a Helm chart in play, and that was
non-obvious in terms of how to integrate:

* Remove `kustomize` render, since we don't need it anymore.
* Create Cloud Parameters that match the Helm configuration variables
  that we need to match in the Helm configuration.
* Also moved cloudbuild.yaml to `script:`

Next is the Agones deployments!

Work on googleforgames#181
markmandel added a commit that referenced this issue Apr 24, 2024
@markmandel
Move Platform/Open Match to Cloud Deploy Params (#257)
ea29f54 
This was a fun one as we have a Helm chart in play, and that was
non-obvious in terms of how to integrate:

* Remove `kustomize` render, since we don't need it anymore.
* Create Cloud Parameters that match the Helm configuration variables
  that we need to match in the Helm configuration.
* Also moved cloudbuild.yaml to `script:`

Next is the Agones deployments!

Work on #181
markmandel added a commit to markmandel/global-multiplayer-demo that referenced this issue May 22, 2024
@markmandel
Agones Installation to Cloud Deploy Params
71c4edb 
This is the last piece of removing generating local files from the
Terraform configuration to use with Cloud Deploy - everything has now
been moved to Cloud Deploy Parameters!

This moves the installation of Agones' into each cluster to use a Cloud
Deploy parameter set on each Cloud Deploy Target.

This also simplifies the Skaffold configuration to remove Kustomize from
the yaml.

Closes googleforgames#181
markmandel added a commit to markmandel/global-multiplayer-demo that referenced this issue May 22, 2024
@markmandel
Agones Installation to Cloud Deploy Params
481480a 
This is the last piece of removing generating local files from the
Terraform configuration to use with Cloud Deploy - everything has now
been moved to Cloud Deploy Parameters!

This moves the installation of Agones' into each cluster to use a Cloud
Deploy parameter set on each Cloud Deploy Target.

This also simplifies the Skaffold configuration to remove Kustomize from
the yaml.

Closes googleforgames#181
@markmandel markmandel mentioned this issue May 22, 2024
Merged
markmandel added a commit that referenced this issue May 23, 2024
@markmandel
Agones Installation to Cloud Deploy Params (#260)
a0bec03 
This is the last piece of removing generating local files from the
Terraform configuration to use with Cloud Deploy - everything has now
been moved to Cloud Deploy Parameters!

This moves the installation of Agones' into each cluster to use a Cloud
Deploy parameter set on each Cloud Deploy Target.

This also simplifies the Skaffold configuration to remove Kustomize from
the yaml.

Closes #181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Agones Installation to Cloud Deploy Params markmandel/global-multiplayer-demo
1 participant
@markmandel