Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodejs): Add constraintsFiltering to Node.js's renovate.json Template #1871

Open
danielbankhead opened this issue Sep 26, 2023 · 0 comments
Assignees
Labels
lang: nodejs Issues specific to JavaScript or TypeScript. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@danielbankhead
Copy link
Member

Today we constantly receive a number of PRs for dependencies that aren't compatible with our version of Node.js. E.g.:

Sometimes we accidentally merge these PRs, causing issues for us - and potentially customers:

We can greatly reduce this toil by setting renovate's constraintsfiltering option to strict here: synthtool/gcp/templates/node_library/renovate.json

Note: this can potentially work for other languages as well, including Python.

Discussion: renovatebot/renovate#24679

@chingor13 chingor13 assigned sofisl and unassigned chingor13 Sep 27, 2023
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. lang: nodejs Issues specific to JavaScript or TypeScript. labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: nodejs Issues specific to JavaScript or TypeScript. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants