Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test dependencies should all be pinned to avoid future issues #341

Open
dandhlee opened this issue Dec 8, 2023 · 0 comments
Open

Test dependencies should all be pinned to avoid future issues #341

dandhlee opened this issue Dec 8, 2023 · 0 comments
Assignees
@dandhlee
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@dandhlee
Copy link
Collaborator

dandhlee commented Dec 8, 2023

Not all dependencies are pinned strictly, so we've had some issues running tests and being very confused as to why golden test data would be changed.

All dependencies should be pinned, but will have to see if it's worth the benefit of having potentially stale test data.
@dandhlee dandhlee added type: cleanup An internal cleanup or hygiene concern. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 8, 2023
@dandhlee dandhlee self-assigned this Dec 8, 2023
@dandhlee dandhlee mentioned this issue Dec 8, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dandhlee dandhlee

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dandhlee