Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate BaseSerializationTest to Junit 5 after downstream libraries migrate to Junit 5 #2763

Open
JoeWang1127 opened this issue May 10, 2024 · 1 comment
Open

Migrate BaseSerializationTest to Junit 5 after downstream libraries migrate to Junit 5 #2763

JoeWang1127 opened this issue May 10, 2024 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@JoeWang1127
Copy link
Collaborator

JoeWang1127 commented May 10, 2024 •
edited

BaseSerializationTest is extended in downstream libraries, e.g., java-logging, and these libraries still use Junit 4.
Migrating this class to Junit 5 before downstream libraries will cause test failures in downstream libraries.

Related to #2726.
@JoeWang1127 JoeWang1127 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 10, 2024
@JoeWang1127 JoeWang1127 mentioned this issue May 10, 2024
Merged
@JoeWang1127 JoeWang1127 added type: cleanup An internal cleanup or hygiene concern. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 10, 2024
@blakeli0 blakeli0 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 21, 2024
@JoeWang1127
Copy link
Collaborator Author

Tests in java-storage also extend BaseSerializationTest.

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:testCompile (default-testCompile) on project google-cloud-storage: Compilation failure
Error:  /home/runner/work/sdk-platform-java/sdk-platform-java/java-shared-dependencies/target/java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/SerializationTest.java:[369,3] method does not override or implement a method from a supertype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blakeli0 @JoeWang1127