Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api versioning showcase it tests: followup on showcase updates and update tests accordingly #2744

Open
zhumin8 opened this issue May 7, 2024 · 0 comments
Open

api versioning showcase it tests: followup on showcase updates and update tests accordingly #2744

zhumin8 opened this issue May 7, 2024 · 0 comments
Assignees
@zhumin8
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented May 7, 2024

context:

sdk-platform-java/showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITApiVersionHeaders.java

Lines 31 to 34 in f30f325

// TODO: add testing on error responses once feat is implemented in showcase.
// https://github.com/googleapis/gapic-showcase/pull/1456
// TODO: watch for showcase gRPC trailer changes suggested in
// https://github.com/googleapis/gapic-showcase/pull/1509#issuecomment-2089147103

@zhumin8 zhumin8 self-assigned this May 7, 2024
@zhumin8 zhumin8 added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 7, 2024
@zhumin8 zhumin8 mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhumin8 zhumin8

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhumin8