Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make library generation unit tests a required check #2733

Open
JoeWang1127 opened this issue May 5, 2024 · 1 comment
Open

Make library generation unit tests a required check #2733

JoeWang1127 opened this issue May 5, 2024 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@JoeWang1127
Copy link
Collaborator

The library-generation-unit-tests sprouts two jobs: library-generation-unit-tests (8, macos-12) and library-generation-unit-tests (8, ubuntu-22.04).

The behavior of this check when setting library-generation-unit-tests (the parent job) as required:

  • On pull request that doesn't change library_generation directory: checks initiate and return result.
  • On pull request that changes library_generation directory: library-generation-unit-tests is stuck.

The behavior of this check when setting two child jobs as required:

  • On pull request that doesn't change library_generation directory: library-generation-unit-tests (8, macos-12) and library-generation-unit-tests (8, ubuntu-22.04) are stuck.
  • On pull request that changes library_generation directory: checks initiate and return result.

The behavior of this check when setting parent and two child jobs as required:

  • On pull request that doesn't change library_generation directory: library-generation-unit-tests (8, macos-12) and library-generation-unit-tests (8, ubuntu-22.04) are stuck.
  • On pull request that changes library_generation directory: library-generation-unit-tests is stuck.
@JoeWang1127 JoeWang1127 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 5, 2024
@JoeWang1127
Copy link
Collaborator Author

A potential solution: remove unit tests on macos since it adds little value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoeWang1127