Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downstream check should include changes from the generator #2685

Open
blakeli0 opened this issue Apr 24, 2024 · 1 comment
Open

Downstream check should include changes from the generator #2685

blakeli0 opened this issue Apr 24, 2024 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@blakeli0
Copy link
Collaborator

blakeli0 commented Apr 24, 2024 •
edited

We currently have downstream check that validates any changes in Gax or shared dependencies would not break downstream(java-bigtable etc.) libraries. However, it does not include changes from the generator, which caused the downstream libraries to fail. It happened recently for bigtable in the generator update PR.
It was not possible to do so in the past due to BazelBot and Owlbot are not in this repo. Now that we have hermetic build, we can test downstream libraries with changes from the generator as well.
@blakeli0
Copy link
Collaborator Author

@lqiu96 Feel free to add more info.
cc: @JoeWang1127 @diegomarquezp

@zhumin8 zhumin8 added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhumin8 @blakeli0