Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC's Paged Callables are not being Traced #2627

Open
lqiu96 opened this issue Apr 8, 2024 · 1 comment
Open

gRPC's Paged Callables are not being Traced #2627

lqiu96 opened this issue Apr 8, 2024 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lqiu96
Copy link
Contributor

lqiu96 commented Apr 8, 2024

From gRPC's CallableFactory:

public static <RequestT, ResponseT, PagedListResponseT>
UnaryCallable<RequestT, PagedListResponseT> createPagedCallable(
GrpcCallSettings<RequestT, ResponseT> grpcCallSettings,
PagedCallSettings<RequestT, ResponseT, PagedListResponseT> pagedCallSettings,
ClientContext clientContext) {
UnaryCallable<RequestT, ResponseT> innerCallable =
createBaseUnaryCallable(grpcCallSettings, pagedCallSettings, clientContext);
UnaryCallable<RequestT, PagedListResponseT> pagedCallable =
Callables.paged(innerCallable, pagedCallSettings);
return pagedCallable.withDefaultCallContext(clientContext.getDefaultCallContext());
}

Paged Callables do not have a TracedPagedCallable equivalent which implements tracing. It is possible that we can reused the TracedUnaryCallable, but that requires some investigation.

@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 8, 2024
@lqiu96 lqiu96 self-assigned this Apr 8, 2024
@blakeli0
Copy link
Collaborator

blakeli0 commented Apr 9, 2024

We should add a TracedPagedCallable similar to TracedUnaryCallable, and test with Showcase

@lqiu96 lqiu96 removed their assignment Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants