Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove old Ruby and C# rules #84

Conversation

viacheslav-rostovtsev
Copy link
Member

No description provided.

@viacheslav-rostovtsev viacheslav-rostovtsev requested a review from a team as a code owner November 2, 2021 02:19
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2021
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray - thanks for doing this!

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please be aware that there is a chance that these rules, while probably not being used, are still imported somewhere (we just need to be prepared to fix that once this is pushed)

@viacheslav-rostovtsev
Copy link
Member Author

I tested the googleapis and that seemed to build fine, but I'll be keeping an eye out.

@viacheslav-rostovtsev viacheslav-rostovtsev merged commit f2e590d into googleapis:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants