Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): map operation_metadata.proto to common_proto #77

Merged
merged 6 commits into from
Sep 29, 2021

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Sep 28, 2021

Properly generate dependencies for google/cloud/common/operation_metadata.proto for the proto_library target and the Java & Go targets. Also include the common_proto target in the nodejs_gapic_assembly_pkg deps so that the proto is packaged with the client and is resolvable.

@noahdietz noahdietz requested a review from a team as a code owner September 28, 2021 23:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2021
@noahdietz
Copy link
Contributor Author

I've tested this in googleapis with the google/cloud/filestore API, the impetus for this change.

@noahdietz noahdietz merged commit f078303 into googleapis:main Sep 29, 2021
@noahdietz noahdietz deleted the common-metadata-proto branch September 29, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants