Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make C# generated proto files end with .g.cs #76

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Sep 22, 2021

This was already done for the gRPC plugin; this is for standard
type generation - messages etc.

Note: I don't know how to test this change, and definitely don't want to merge before testing. The README shows how to use the rules in this library, but not how to test changes...

This was already done for the gRPC plugin; this is for standard
type generation - messages etc.
@jskeet jskeet requested a review from a team as a code owner September 22, 2021 13:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2021
Copy link
Member

@viacheslav-rostovtsev viacheslav-rostovtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viacheslav-rostovtsev viacheslav-rostovtsev merged commit 7698d5c into googleapis:main Sep 29, 2021
@jskeet jskeet deleted the csharp-extension branch October 27, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants