[build_gen] fix(monolith): gate GAPIC build_gen on service.yaml or grpc_service_config.json #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
miraleung
changed the title
alexander-fenster
approved these changes
Mar 25, 2021
noahdietz
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gates GAPIC-build file generation on the presence of
service.yamlorgrpc_service_config.json. APIs who want just the raw, proto-only build file don't need to use these files, so there is no need for them have either alongside their protos.A cursory search over all protos with the following query string shows that this is a sufficiently-good heuristic.
f:third_party/googleapis f:BUILD.bazel "java_proto_library" -"java_gapic_library"