Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge on Green: Handle PRs with dismissed reviews #378

Closed
crwilcox opened this issue Mar 7, 2020 · 3 comments
Closed

Merge on Green: Handle PRs with dismissed reviews #378

crwilcox opened this issue Mar 7, 2020 · 3 comments
Assignees
@sofisl
Labels
bot: merge on green type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Mar 7, 2020

It seems to me that PRs that have dimissed reviews aren't merging ever.
Example: googleapis/python-storage#48

tseaver leaves request for changes
crwilcox dismisses
crwilcox approves
franknatividad approves.

Is it possible the request for changes is blocking despite the dismissal of the review?
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 7, 2020
@JustinBeckwith JustinBeckwith added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 11, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Mar 11, 2020
@sofisl
Copy link
Contributor

sofisl commented Mar 12, 2020

Hi Chris! From what I can tell, it looks like Ilya left comments and did not approve that PR. According to the logic, if anyone has reviewed and not approved, then it would not get merged. Do you have an example of a PR that has been approved and still has not merged? I'd imagine that's more on the order of a bug, in which case I'd be happy to review!

@sofisl
Copy link
Contributor

sofisl commented Mar 23, 2020

As a heads up, I merged PR #390 which fixes a bug with reviewers: it will allow the PR to merge if the author has left comments. Maybe this was affecting the PR?

@sofisl
Copy link
Contributor

sofisl commented May 20, 2020

Will close this due to inactivity, as I'm pretty sure this issue has been resolved! @crwilcox, feel free to reopen if you see this issue persist :)

@sofisl sofisl closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sofisl sofisl

Labels
bot: merge on green type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JustinBeckwith @crwilcox @tbpg @yoshi-automation @sofisl