Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge-on-green: The bot should post more details if automerge fails #2294

Open
plamut opened this issue Jul 21, 2021 · 1 comment
Open

merge-on-green: The bot should post more details if automerge fails #2294

plamut opened this issue Jul 21, 2021 · 1 comment
Labels
bot: merge on green type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@plamut
Copy link

plamut commented Jul 21, 2021

Recently it happened that the bot did not merge a PR, even though the automerge label was applied, the PR was approved, and all CI check passed. When it works, it usually merges a PR within a few minutes after the checks pass.

In that particular case the bot just posted a comment and removed the automerge label, after which I merged the PR manually without making any changes to it, I just clicked the Merge button.

It would be helpful to know why the bot failed to merge a PR, e.g. was it just an internal glitch or was there something else that reviewers should be aware of.

@chingor13 chingor13 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. bot: merge on green labels Jul 22, 2021
@dandhlee
Copy link
Contributor

dandhlee commented Jul 27, 2021

+1 for being a lot more verbose to failures.

As well, it takes way too long to find out 6 hours after that the PR can't be merged. If the bot can be a bit more verbose right away (and update the comment as the PR updates itself with checks) as to why it's not working, that'd be great. For those who doesn't like the bot to be noisy, an automerge:quiet label that does the exact same work but without being verbose would make them happy as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants