Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Owl-bot post processor check missing in PR from python-dialogflow #1877

Closed
parthea opened this issue May 25, 2021 · 4 comments
Closed
Assignees
Labels
bot: owl-bot needs more info This issue needs more information from the customer to proceed. type: question Request for information or clarification. Not an issue.

Comments

@parthea
Copy link
Contributor

parthea commented May 25, 2021

In this PR from python-dialogflow the owl bot post processor didn't run. I've seen the owl bot check run successfully in another PR that I reviewed. How do I go about troubleshooting why the owl bot check was missing? I triggered the post processing check to run by adding the label owlbot:run so we don't block the API feature from being merged.

@sofisl sofisl added the type: docs Improvement to the documentation for an API. label May 25, 2021
@sofisl
Copy link
Contributor

sofisl commented May 25, 2021

@SurferJeffAtGoogle, I've labeled this as a docs issue, but feel free to relabel as appropriate.

@SurferJeffAtGoogle
Copy link
Contributor

I expected owl bot post processor to run, but it never did.

@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed type: docs Improvement to the documentation for an API. labels May 26, 2021
@bcoe bcoe added type: question Request for information or clarification. Not an issue. needs more info This issue needs more information from the customer to proceed. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 27, 2021
@bcoe
Copy link
Contributor

bcoe commented May 27, 2021

@parthea @SurferJeffAtGoogle I see OwlBot post processor having run on both those PRs shared, to dig into this I believe I would need to see a PR where the problem was fresh, i.e., it hadn't already been merged without the post processor having run.

@bcoe
Copy link
Contributor

bcoe commented May 27, 2021

I dug into the specific issue having trouble, and the reason owlbot:run did not run on subsequent runs was that the branch was deleted.

Please let us know in chat if this happens again, and we can look at the build history and see why the trigger failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: owl-bot needs more info This issue needs more information from the customer to proceed. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

4 participants