feat(gcf-utils): change the method signature of addOrUpdateIssueComment #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tmatsuo
changed the title
added 2 commits
November 16, 2020 17:16
Now it only requires Octokit, instead of Context. The intention is to allow us to use this function from the cron hander. In the test app, I needed to do double cast to avoid an error.
tmatsuo
force-pushed
the
gcf-utils-change
branch
from
b8cab5a
to
1bfacb1
Compare
|
Rebased. This is technically a breaking change, but this function is just added and we haven't released gcf-utils yet, so it should be fine to merge in my opinion. |
bcoe
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1130
Now it only requires Octokit, instead of Context.
The intention is to allow us to use this function from the cron hander.