Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge on green: 'not-mergeable' comment left on merged PR #1088

Closed
busunkim96 opened this issue Nov 6, 2020 · 4 comments
Closed

merge on green: 'not-mergeable' comment left on merged PR #1088

busunkim96 opened this issue Nov 6, 2020 · 4 comments
Assignees
@sofisl
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@busunkim96
Copy link
Contributor

googleapis/python-billingbudgets#53

Yesterday (11/04/2020)

  • I opened the above PR.
  • I added (and then removed) the automerge label.
  • I merged the PR.

Today (11/05/2020)

  • About 24 hours after the merge, gcf-merge-on-green commented with the below:

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

There is no impact to my workflow, but I wanted to report this in case it was indicative of some other issue.
@busunkim96
Copy link
Contributor Author

busunkim96 commented Nov 6, 2020 •
edited

Similar behavior observed GoogleCloudPlatform/python-docs-samples#4946. This PR was closed (not merged) and does not have the automerge label anymore. The bot commented once per minute through the night.

#1088
image

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 6, 2020
@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Nov 6, 2020
@bcoe
Copy link
Contributor

bcoe commented Nov 6, 2020

@sofisl if you're so inclined, please feel free to make a case for this being p2 😄

@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Nov 6, 2020
@sofisl
Copy link
Contributor

sofisl commented Nov 6, 2020

@busunkim96, thanks for bringing this up! I will look into this ASAP.

@sofisl sofisl mentioned this issue Nov 6, 2020
Merged
@busunkim96
Copy link
Contributor Author

Closed by #1091. Thanks @sofisl!

@sofisl sofisl mentioned this issue Nov 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sofisl sofisl

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bcoe @busunkim96 @yoshi-automation @sofisl