Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-please bot is attempting the release of same version after every new merge #988

Closed
vi3k6i5 opened this issue Jul 29, 2021 · 7 comments · Fixed by googleapis/repo-automation-bots#2331
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vi3k6i5
Copy link

vi3k6i5 commented Jul 29, 2021

After every PR merge on github repo release-please bot is trying to do a release of an already released version.

Example:
Successful release of 2.2.1b2 : googleapis/python-spanner-django#687

still reattempted by bot:

googleapis/python-spanner-django#689
googleapis/python-spanner-django#690
Any idea what is causing this and how to resolve it ?

There is a whole list with 2.2.1b1 https://github.com/googleapis/python-spanner-django/pulls?q=is%3Apr+is%3Aclosed

  1. Is this a client library issue or a product issue?
  • Not sure, maybe just a client level issue in configuration or maybe a version name mismatch from the django client.
  1. Did someone already solve this?
  • NA
  1. Do you have a support contract?
  • NA

Environment details

  • OS: NA
  • Node.js version: NA
  • npm version: NA
  • release-please version: latest in production

Steps to reproduce

  1. Merge a commit to repo https://github.com/googleapis/python-spanner-django master branch.
  2. Release please bot will create a new release PR similar to this: chore: release 2.2.1b2 Delete LICENSE #690

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 30, 2021
@sofisl sofisl added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 30, 2021
@bcoe
Copy link
Contributor

bcoe commented Jul 30, 2021

We don't currently support pre-releases with the format 1.0.0b1, 1.0.0b2, etc. The syntax Node.js and Java use for this is to have the prerelease version after a hyphen:

1.0.0-beta.1
1.0.0-beta.2
etc.

Is 1.0.0b1 common syntax for Python?

@bcoe
Copy link
Contributor

bcoe commented Jul 30, 2021

@chingor13 @joeldodge79 another need for a custom version bumping strategy?

@chingor13
Copy link
Contributor

chingor13 commented Jul 30, 2021

@chingor13 @joeldodge79 another need for a custom version bumping strategy?

Probably. This is related to @parthea's feature request and requires thought about how to signal the version bump. How do we signal whether the next version should be 1.0.0b2, 1.1.0b1, 1.0.0 or 1.1.0?

@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Aug 1, 2021
@tseaver
Copy link

tseaver commented Aug 2, 2021

@bcoe PEP 440 describes X.YbZ as the "normal" form, and accepts some others such as X.Y-beta.Z which are expected to be normalized back to it by tooling.

@chingor13 I would expect that release-please would stay with -b# unless / until a PR with Release-As: bumped it (i.e., no automation).

@bcoe
Copy link
Contributor

bcoe commented Aug 4, 2021

@vi3k6i5 I believe this should be corrected now, I believe before the fix this PR would have contained all changes since last non alpha or beta release:

googleapis/python-spanner-django#698

@bcoe bcoe reopened this Aug 5, 2021
@bcoe
Copy link
Contributor

bcoe commented Aug 5, 2021

release-please had to be rolled back due to an unrelated issue, I will close this issue once we re-land.

@bcoe bcoe closed this as completed Aug 6, 2021
@bcoe
Copy link
Contributor

bcoe commented Aug 6, 2021

fix has been redeployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants